narendly commented on a change in pull request #519: Refine the rebalance scope
calculating logic in the WAGED rebalancer.
URL: https://github.com/apache/helix/pull/519#discussion_r337799390
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
##########
@@ -254,8 +255,6 @@ public void close() {
if (clusterChanges.keySet().stream()
.anyMatch(GLOBAL_REBALANCE_REQUIRED_CHANGE_TYPES::contains)) {
refreshBaseline(clusterData, clusterChanges, resourceMap,
currentStateOutput);
- // Inject a cluster config change for large scale partial rebalance once
the baseline changed.
- clusterChanges.putIfAbsent(HelixConstants.ChangeType.CLUSTER_CONFIG,
Collections.emptySet());
Review comment:
What is this change for? This is not discussed in your PR description or
your issue.
It seems like this was a bit of a hack to trigger a global baseline
calculation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
