narendly commented on a change in pull request #519: Refine the rebalance scope
calculating logic in the WAGED rebalancer.
URL: https://github.com/apache/helix/pull/519#discussion_r339168993
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/changedetector/ResourceChangeDetector.java
##########
@@ -50,8 +51,13 @@
private Map<HelixConstants.ChangeType, Collection<String>> _addedItems = new
HashMap<>();
private Map<HelixConstants.ChangeType, Collection<String>> _removedItems =
new HashMap<>();
- public ResourceChangeDetector() {
+ public ResourceChangeDetector(boolean ignoreHelixSourceChange) {
_newSnapshot = new ResourceChangeSnapshot();
+ _ignoreHelixSourceChange = ignoreHelixSourceChange;
+ }
Review comment:
Discussed with @jiajunwang offline. We will go with the private field for
now to avoid overengineering.
However, could you rename the field so it is clearer?
_ignoreInternalControllerFields or ignoreControllerGeneratedFields and make
it clear that IdealState's map and list fields are written to by the
controller, so setting this field to true will ignore IdealState's map and list
field changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
