narendly commented on a change in pull request #519: Refine the rebalance scope
calculating logic in the WAGED rebalancer.
URL: https://github.com/apache/helix/pull/519#discussion_r338370730
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/changedetector/ResourceChangeDetector.java
##########
@@ -50,8 +51,13 @@
private Map<HelixConstants.ChangeType, Collection<String>> _addedItems = new
HashMap<>();
private Map<HelixConstants.ChangeType, Collection<String>> _removedItems =
new HashMap<>();
- public ResourceChangeDetector() {
+ public ResourceChangeDetector(boolean ignoreHelixSourceChange) {
_newSnapshot = new ResourceChangeSnapshot();
+ _ignoreHelixSourceChange = ignoreHelixSourceChange;
+ }
Review comment:
@jiajunwang This is not what we agreed on during our offline discussion. I
think the idea was to extend ResourceChangeDetector (for example,
ControllerResourceChangeDetector or WagedRebalancerChangeDetector), that simply
overrides a method and includes the filtering/trimming logic.
Adding a field like `_ignoreHelixSourceChange` *was* an option that we
discussed, but we both agreed that this would make the code not very clean.
Could we please try the subclass method like we agreed to earlier?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
