jiajunwang commented on a change in pull request #520: Refactor soft
constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r339246203
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterContext.java
##########
@@ -35,14 +35,14 @@
* This class tracks the rebalance-related global cluster status.
*/
public class ClusterContext {
- private final static float ERROR_MARGIN_FOR_ESTIMATED_MAX_COUNT = 1.1f;
-
// This estimation helps to ensure global partition count evenness
private final int _estimatedMaxPartitionCount;
// This estimation helps to ensure global top state replica count evenness
private final int _estimatedMaxTopStateCount;
// This estimation helps to ensure per-resource partition count evenness
private final Map<String, Integer> _estimatedMaxPartitionByResource = new
HashMap<>();
+ // This estmations helps to ensure global resource usage evenness.
+ private final float _estimatedMaxUtilization;
Review comment:
Same as what I replied previously, I think "estimate" is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
