jiajunwang commented on a change in pull request #520: Refactor soft
constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r339246740
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterContext.java
##########
@@ -71,9 +74,31 @@
int replicaCnt = Math.max(1, estimateAvgReplicaCount(replicas,
instanceCount));
_estimatedMaxPartitionByResource.put(entry.getKey(), replicaCnt);
- totalTopStateReplicas +=
entry.getValue().stream().filter(AssignableReplica::isReplicaTopState).count();
+ for (AssignableReplica replica : entry.getValue()) {
+ if (replica.isReplicaTopState()) {
+ totalTopStateReplicas += 1;
+ }
+ replica.getCapacity().entrySet().stream().forEach(capacityEntry ->
totalUsage
+ .compute(capacityEntry.getKey(),
+ (k, v) -> (v == null) ? capacityEntry.getValue() : (v +
capacityEntry.getValue())));
+ }
+ }
+ nodeSet.stream().forEach(node ->
node.getMaxCapacity().entrySet().stream().forEach(
+ capacityEntry -> totalCapacity.compute(capacityEntry.getKey(),
+ (k, v) -> (v == null) ? capacityEntry.getValue() : (v +
capacityEntry.getValue()))));
+
+ if (totalCapacity.isEmpty()) {
+ _estimatedMaxUtilization = 1f;
+ } else {
+ float estimatedMaxUsage = 0;
+ for (String capacityKey : totalCapacity.keySet()) {
+ int maxCapacity = totalCapacity.get(capacityKey);
+ int usage = totalUsage.getOrDefault(capacityKey, 0);
+ float utilization = (maxCapacity == 0) ? 1 : (float) usage /
maxCapacity;
+ estimatedMaxUsage = Math.max(estimatedMaxUsage, utilization);
+ }
+ _estimatedMaxUtilization = estimatedMaxUsage;
Review comment:
Since we had a short meeting already, let me resolve this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
