jiajunwang commented on a change in pull request #520: Refactor soft constraints to simply the algorithm and fix potential issues. URL: https://github.com/apache/helix/pull/520#discussion_r339254050
########## File path: helix-core/src/main/resources/soft-constraint-weight.properties ########## @@ -17,8 +17,10 @@ # under the License. # -PartitionMovementConstraint=1f -InstancePartitionsCountConstraint=0.3f -ResourcePartitionAntiAffinityConstraint=0.1f -ResourceTopStateAntiAffinityConstraint=0.1f -MaxCapacityUsageInstanceConstraint=0.5f \ No newline at end of file +# Define the constraint weights for the WAGED rebalancer in this file. Review comment: We just need one set of default values. So the file can be defaulted to be empty. I'm also fine with putting the default values to the resource file. But it would be hard to test and play with the code while we are developing. I mean either way works. Just don't keep both. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
