narendly commented on a change in pull request #543: Change change detector to
a regular field in the WAGED rebalancer instead of static threadlocal.
URL: https://github.com/apache/helix/pull/543#discussion_r339281626
##########
File path:
helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/TestWagedRebalancer.java
##########
@@ -440,15 +444,15 @@ public void testRebalanceOnChanges() throws IOException,
HelixRebalanceException
// calculate the assignment for both resources.
newIdealStates =
rebalancer.computeNewIdealStates(clusterData, resourceMap, new
CurrentStateOutput());
- algorithmResult = _algorithm.getRebalanceResult();
+ newAlgorithmResult = _algorithm.getRebalanceResult();
// Verify that both resource has been included in the calculation.
- validateRebalanceResult(resourceMap, newIdealStates, algorithmResult);
- // Both assignment state should be empty since no cluster topology change.
+ validateRebalanceResult(resourceMap, newIdealStates, newAlgorithmResult);
+ // There is nothing changes the baseline.
baseline = _metadataStore.getBaseline();
- Assert.assertEquals(baseline, Collections.emptyMap());
- // The best possible assignment should be present.
+ Assert.assertEquals(baseline, algorithmResult);
+ // The best possible assignment has been updated as long as
computeNewIdealStates() is called.
Review comment:
The BestPossible assignment should have been updated since
computeNewIdealStates() should have been called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
