narendly commented on a change in pull request #543: Change change detector to 
a regular field in the WAGED rebalancer instead of static threadlocal.
URL: https://github.com/apache/helix/pull/543#discussion_r339281658
 
 

 ##########
 File path: 
helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/TestWagedRebalancerMetrics.java
 ##########
 @@ -123,6 +123,8 @@ public void testWagedRebalanceMetrics()
     // Cluster config change will trigger baseline recalculation and partial 
rebalance.
     when(clusterData.getRefreshedChangeTypes())
         
.thenReturn(Collections.singleton(HelixConstants.ChangeType.CLUSTER_CONFIG));
+    // Update the config so the cluster config will be marked as changed.
 
 Review comment:
   Add a field to the cluster config so the cluster config will be marked as 
changed in the change detector.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to