narendly commented on a change in pull request #632: Asynchronously calculating
the Baseline
URL: https://github.com/apache/helix/pull/632#discussion_r351632818
##########
File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java
##########
@@ -94,7 +94,12 @@
// The preference of the rebalance result.
// EVENNESS - Evenness of the resource utilization, partition, and top
state distribution.
// LESS_MOVEMENT - the tendency of keeping the current assignment instead
of moving the partition for optimal assignment.
- REBALANCE_PREFERENCE
+ REBALANCE_PREFERENCE,
+ // Specify if the WAGED rebalancer should asynchronously calculating the
global rebalance result.
+ // Note that asynchronously calculating will reduce the rebalance delay
but may cause more
+ // partition movements/
+ // Default to be true.
+ ASYNC_GLOBAL_REBALANCE
Review comment:
Let's rename this field to something like "GLOBAL_REBALANCE_ASYNC_MODE".
Also in the inline comment, make it clear that this is for WAGED rebalancer.
Another suggestion is to make a separate constant section for WAGED-related
variables.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
