narendly commented on a change in pull request #632: Asynchronously calculating
the Baseline
URL: https://github.com/apache/helix/pull/632#discussion_r351635123
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -220,17 +221,24 @@ public GenericHelixController(String clusterName,
Set<Pipeline.Type> enabledPipe
class RebalanceTask extends TimerTask {
final HelixManager _manager;
final ClusterEventType _clusterEventType;
+ private final boolean _requestCacheRefresh;
private long _nextRebalanceTime;
public RebalanceTask(HelixManager manager, ClusterEventType
clusterEventType) {
this(manager, clusterEventType, -1);
+ }
+ public RebalanceTask(HelixManager manager, ClusterEventType
clusterEventType,
Review comment:
I am going to make an argument that the change around
RebalanceTask/GenericHelixController could be a separate PR. Could you please
consider making it a separate PR to make the development/review go smoother and
more modular?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
