jiajunwang commented on a change in pull request #632: Asynchronously
calculating the Baseline
URL: https://github.com/apache/helix/pull/632#discussion_r351980713
##########
File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java
##########
@@ -822,6 +828,19 @@ public void
setGlobalRebalancePreference(Map<GlobalRebalancePreferenceKey, Integ
return DEFAULT_GLOBAL_REBALANCE_PREFERENCE;
}
+ /**
+ * Set the asynchronous global rebalance option.
+ * @param isAsync true if the global rebalance should be calculated
asynchronously
+ */
+ public void setAsyncGlobalRebalance(boolean isAsync) {
Review comment:
I had a discussion with Junkai before, "enableXXXXXX" in our code is a bad
naming. It is very confusing if you are disabling the option but you are still
calling enableXXXX() method.
I would change it to be setGlobalRebalanceAsyncMode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
