jiajunwang commented on a change in pull request #632: Asynchronously
calculating the Baseline
URL: https://github.com/apache/helix/pull/632#discussion_r360529519
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
##########
@@ -199,23 +211,33 @@ private WagedRebalancer(AssignmentMetadataStore
assignmentMetadataStore,
BaselineDivergenceGauge.class);
_changeDetector = new ResourceChangeDetector(true);
+
+ _baselineCalculateExecutor = Executors.newSingleThreadExecutor();
+ _asyncGlobalRebalance = asyncGlobalRebalance;
+ }
+
+ // Update the global rebalance mode to be asynchronous or synchronous
+ public void setGlobalRebalanceAsyncMode(boolean asyncGlobalRebalance) {
+ _asyncGlobalRebalance = asyncGlobalRebalance;
}
- // Update the rebalancer preference configuration if the new preference is
different from the
- // current preference configuration.
- public void updatePreference(
+ // Update the rebalancer pereference if the new options are different from
the current
+ // pereference.
+ public synchronized void updateRebalancePereference(
Review comment:
yeah, a typo here. Will fix.
Let's just keep it preference. We can potentially merge the options as I did
originally. But for now, I don't have the strong motivation of doing that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
