jiajunwang commented on a change in pull request #637: Add new WAGED rebalancer
config item "GLOBAL_REBALANCE_ASYNC_MODE".
URL: https://github.com/apache/helix/pull/637#discussion_r352823880
##########
File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java
##########
@@ -822,6 +840,19 @@ public void
setGlobalRebalancePreference(Map<GlobalRebalancePreferenceKey, Integ
return DEFAULT_GLOBAL_REBALANCE_PREFERENCE;
}
+ /**
+ * Set the asynchronous global rebalance mode.
+ * @param isAsync true if the global rebalance should be performed
asynchronously
+ */
+ public void setGlobalRebalanceAsyncMode(boolean isAsync) {
Review comment:
Please see my reply in #632. enableXXXX is not a preferred name.
Considering enableXXXX(false), it is very easy to get lost if you are
enabling it or disabling it.
setXXXX is more straight forward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
