jiajunwang commented on a change in pull request #637: Add new WAGED rebalancer
config item "GLOBAL_REBALANCE_ASYNC_MODE".
URL: https://github.com/apache/helix/pull/637#discussion_r352823237
##########
File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java
##########
@@ -94,7 +99,15 @@
// The preference of the rebalance result.
// EVENNESS - Evenness of the resource utilization, partition, and top
state distribution.
// LESS_MOVEMENT - the tendency of keeping the current assignment instead
of moving the partition for optimal assignment.
- REBALANCE_PREFERENCE
+ REBALANCE_PREFERENCE,
+ // Specify if the WAGED rebalancer should asynchronously perform global
rebalance.
+ // Note that asynchronous calculation will reduce the rebalance delay but
may cause more
+ // partition movements. This is because the partial rebalance will be
preformed with an stale
+ // baseline. The rebalance result would be an intermediate one and could
be changed again when
+ // a new baseline is calculated.
+ //
Review comment:
It is not easy to make it clear here. If one needs to understand the whole
logic through reading, this people will need to read a lot anyway. So I think
we just add a link to the design doc in github wiki.
If the doc is still not quite clear, we can fix the paragraphs there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
