pkuwm commented on a change in pull request #644: Add new interface
IZkStateListener to provide session aware handleNewSession for ZkHelixManager
URL: https://github.com/apache/helix/pull/644#discussion_r355299022
##########
File path:
helix-core/src/test/java/org/apache/helix/manager/zk/TestRawZkClient.java
##########
@@ -91,29 +94,137 @@ void testGetStat() {
AssertJUnit.assertNotSame(stat, newStat);
}
- @Test()
- void testSessionExpire() throws Exception {
- IZkStateListener listener = new IZkStateListener() {
+ /*
+ * Tests subscribing state changes for helix's IZkStateListener.
+ */
+ @Test
+ public void testSubscribeStateChanges() {
+ int numListeners = _zkClient.numberOfListeners();
Review comment:
My thought was, since _zkClient is a global var in the parent class. I can't
assume number of listeners is 0. There might already be some listeners in the
_zkClient. So I just get the number, instead of 0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
