pkuwm commented on a change in pull request #644: Add new interface
IZkStateListener to provide session aware handleNewSession for ZkHelixManager
URL: https://github.com/apache/helix/pull/644#discussion_r356229184
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java
##########
@@ -1754,4 +1784,64 @@ private void recordStateChange(boolean stateChanged,
boolean dataChanged) {
}
}
}
+
+ /**
+ * Creates a {@link org.apache.helix.manager.zk.zookeeper.IZkStateListener}
that wraps a default
+ * implementation of {@link org.I0Itec.zkclient.IZkStateListener}, which
means the returned
+ * listener runs the methods of {@link org.I0Itec.zkclient.IZkStateListener}.
+ * This is for backward compatibility with {@link
org.I0Itec.zkclient.IZkStateListener}.
+ */
+ private static class IZkStateListenerI0ItecImpl implements IZkStateListener {
Review comment:
Thanks for the suggestion. I actually had the same concern when implementing
this class. I tried to put this class in the interface, but realized that
ZkClient is not in the same package with the interface. If we want to access
this implantation class, we have to make it public in the interface, which is
not what I want.
If I don't understand your point correctly, please correct me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
