i3wangyi commented on a change in pull request #639: Refine the WAGED
rebalancer to minimize the partial rebalance workload.
URL: https://github.com/apache/helix/pull/639#discussion_r358974468
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
##########
@@ -306,14 +307,15 @@ public void close() {
delayedRebalanceSchedule(clusterData, activeNodes, resourceMap.keySet());
Review comment:
After reading through the whole class, I think this is the right place to
initialize a new instance of the rebalance algorithm based on the current
preference mapping. It could achieve your goal: avoid the race condition,
prevent different calculation steps uses different objects and my hope: reduce
the number of passed parameters, and remove the private field. Do you think so?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
