i3wangyi commented on a change in pull request #639: Refine the WAGED
rebalancer to minimize the partial rebalance workload.
URL: https://github.com/apache/helix/pull/639#discussion_r359163172
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
##########
@@ -326,32 +328,17 @@ public void close() {
return newIdealStates;
}
- // Coordinate baseline recalculation and partial rebalance according to the
cluster changes.
+ // Coordinate global rebalance and partial rebalance according to the
cluster changes.
protected Map<String, ResourceAssignment> computeBestPossibleAssignment(
Review comment:
The second suggestion is using a override subclass of metaDataAssignment as
the passed instance in the dry-run class. E.g,
```
MetaDataAssignmentDataStore fakeMetaDataAssignmentDataStore = new XXX {
@override
boolean writeToDB() {
// do nothing
}
}
class DryRunRebalancer {
DryRunRebalancer() {
super(fakeMetaDataAssignment)
}
}
```
Will it work? I don't think you will need to override any methods if your
dry-run is trying to get the result and not persisting it at all
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
