jiajunwang commented on a change in pull request #639: Refine the WAGED
rebalancer to minimize the partial rebalance workload.
URL: https://github.com/apache/helix/pull/639#discussion_r359193559
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java
##########
@@ -55,13 +129,14 @@
* @param baselineAssignment The persisted Baseline assignment.
Review comment:
As you can see the complexity of this method, we cannot afford to have any
duplicate logic. Or the maintenance cost would be very high.
I think changing the parameter's name is a good idea. The internal method
could be more generic. There is no reason it needs to understand baseline or
best possible assignment. Let me change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
