jiajunwang commented on a change in pull request #639: Refine the WAGED
rebalancer to minimize the partial rebalance workload.
URL: https://github.com/apache/helix/pull/639#discussion_r359197668
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
##########
@@ -326,32 +328,17 @@ public void close() {
return newIdealStates;
}
- // Coordinate baseline recalculation and partial rebalance according to the
cluster changes.
+ // Coordinate global rebalance and partial rebalance according to the
cluster changes.
protected Map<String, ResourceAssignment> computeBestPossibleAssignment(
Review comment:
Sorry I should have made it clearer. I already did that in the dryrun
rebalancer. But overriding the assignment datastore is not enough. I don't need
to calculate anything in a dryrun rebalancer. That is for the verifier to use.
So I just need to read from the persisted assignment.
In this case, overriding the computing methods is required. Otherwise, we
run the risk that the verifier will calculate different results from the remote
controller. Note the waged rebalancer algorithm is not static as the CrushEd
does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
