narendly commented on a change in pull request #653: add Helix properties
factory and class
URL: https://github.com/apache/helix/pull/653#discussion_r360517579
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
##########
@@ -202,6 +205,11 @@ public ZKHelixManager(String clusterName, String
instanceName, InstanceType inst
public ZKHelixManager(String clusterName, String instanceName, InstanceType
instanceType,
String zkAddress, HelixManagerStateListener stateListener) {
+ this(clusterName, instanceName, instanceType, zkAddress,stateListener,
null);
+ }
+
+ public ZKHelixManager(String clusterName, String instanceName, InstanceType
instanceType,
+ String zkAddress, HelixManagerStateListener stateListener,
HelixParticipantProperty helixParticipantProperty) {
Review comment:
ZKHelixManager is not only used by Participants. It could be created in many
different modes such as Controller, Participant, Controller Participant, and
Spectator. So I do not think adding HelixParticipantProperty in the constructor
is a good idea because you're adding specificity to a general class. Using a
more generic type would be better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
