narendly commented on a change in pull request #653: add Helix properties
factory and class
URL: https://github.com/apache/helix/pull/653#discussion_r360516362
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java
##########
@@ -76,9 +77,16 @@
final StateMachineEngine _stateMachineEngine;
final LiveInstanceInfoProvider _liveInstanceInfoProvider;
final List<PreConnectCallback> _preConnectCallbacks;
+ final HelixParticipantProperty _helixParticipantProperty;
public ParticipantManager(HelixManager manager, HelixZkClient zkclient, int
sessionTimeout,
LiveInstanceInfoProvider liveInstanceInfoProvider,
List<PreConnectCallback> preConnectCallbacks) {
+ this(manager, zkclient, sessionTimeout, liveInstanceInfoProvider,
preConnectCallbacks, null);
Review comment:
Is passing `null` a safe thing to do? Wouldn't it be better to pass in an
empty instance of `HelixParticipantProperty` to avoid potential NPEs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
