narendly commented on a change in pull request #632: Asynchronously calculating
the Baseline
URL: https://github.com/apache/helix/pull/632#discussion_r360574191
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
##########
@@ -443,8 +494,13 @@ private void calculateAndUpdateBaseline(ClusterModel
clusterModel, RebalanceAlgo
} else {
LOG.debug("Assignment Metadata Store is null. Skip persisting the
baseline assignment.");
}
- _globalBaselineCalcLatency.endMeasuringLatency();
- LOG.info("Finish calculating the new baseline.");
+ _baselineCalcLatency.endMeasuringLatency();
+ LOG.info("Global baseline calculation completed and has been persisted
into metadata store.");
+
+ if (isBaselineChanged && shouldSchedulePartialRebalance) {
+ LOG.info("Schedule a new rebalance after the new baseline calculated.");
Review comment:
Nit: "after the new baseline calculated." -> "after the new baseline
calculation has finished"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
