narendly commented on a change in pull request #632: Asynchronously calculating
the Baseline
URL: https://github.com/apache/helix/pull/632#discussion_r351636005
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/changedetector/ResourceChangeSnapshot.java
##########
@@ -130,18 +132,22 @@ private IdealState trimIdealState(IdealState
originalIdealState) {
// Clone the IdealState to avoid modifying the objects in the Cluster Data
Cache, which might
// be used by the other stages in the pipeline.
IdealState trimmedIdealState = new
IdealState(originalIdealState.getRecord());
+ ZNRecord idealStateRecord = trimmedIdealState.getRecord();
Review comment:
Nit: `trimmedIdealStateRecord`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
