jiajunwang commented on a change in pull request #632: Asynchronously
calculating the Baseline
URL: https://github.com/apache/helix/pull/632#discussion_r360586395
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
##########
@@ -79,21 +84,25 @@
.of(ClusterConfig.GlobalRebalancePreferenceKey.EVENNESS, -1,
ClusterConfig.GlobalRebalancePreferenceKey.LESS_MOVEMENT, -1);
+ // To calculate the baseline asynchronously
+ private final ExecutorService _baselineCalculateExecutor;
private final ResourceChangeDetector _changeDetector;
private final HelixManager _manager;
private final MappingCalculator<ResourceControllerDataProvider>
_mappingCalculator;
private final AssignmentMetadataStore _assignmentMetadataStore;
private final MetricCollector _metricCollector;
private final CountMetric _rebalanceFailureCount;
- private final CountMetric _globalBaselineCalcCounter;
- private final LatencyMetric _globalBaselineCalcLatency;
+ private final CountMetric _baselineCalcCounter;
+ private final LatencyMetric _baselineCalcLatency;
Review comment:
It might be for someone. It brings some value to use the same name
everywhere.
Anyway, if you find any globalBaseline in the code that I leftover, feel
free to comment or just change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
