jiajunwang commented on a change in pull request #632: Asynchronously
calculating the Baseline
URL: https://github.com/apache/helix/pull/632#discussion_r360549281
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
##########
@@ -443,8 +494,13 @@ private void calculateAndUpdateBaseline(ClusterModel
clusterModel, RebalanceAlgo
} else {
LOG.debug("Assignment Metadata Store is null. Skip persisting the
baseline assignment.");
}
- _globalBaselineCalcLatency.endMeasuringLatency();
+ _baselineCalcLatency.endMeasuringLatency();
LOG.info("Finish calculating the new baseline.");
+
+ if (isbaselineUpdated && doSchedulePartialRebalance) {
+ LOG.info("Schedule a new rebalance after the new baseline calculated.");
Review comment:
We have the 2 logs here. I agree to make the first one "Global baseline
calculation completed and has been persisted into metadata store." So we have
the complete message when combined.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
