pkuwm commented on a change in pull request #642: Fix handleNewSession creating ephemeral node with expired session URL: https://github.com/apache/helix/pull/642#discussion_r361074549
########## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java ########## @@ -77,14 +76,17 @@ final LiveInstanceInfoProvider _liveInstanceInfoProvider; final List<PreConnectCallback> _preConnectCallbacks; + private final String _sessionId; Review comment: From @lei-xia comment, my understanding is this class ParticipantManager is exposed to be an internal class. It is a default specifier, no other classes in the same package are using it. So I think it is OK to do this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
