pkuwm commented on a change in pull request #642: Fix handleNewSession creating
ephemeral node with expired session
URL: https://github.com/apache/helix/pull/642#discussion_r361075212
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java
##########
@@ -182,7 +200,7 @@ private void createLiveInstance() {
do {
retry = false;
try {
- _zkclient.createEphemeral(liveInstancePath, liveInstance.getRecord());
+ _zkclient.createEphemeral(liveInstancePath, liveInstance.getRecord(),
sessionId);
LOG.info("LiveInstance created, path: " + liveInstancePath + ",
sessionId: " + liveInstance.getEphemeralOwner());
} catch (ZkNodeExistsException e) {
Review comment:
I made a typo. I meant, we don't have to roll back joining cluster. So we
don't have to drop the instanceConfig. Sorry about the confusion. Like current
usage, cluster admins would have to drop the instanceConfig manually if they
want. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
