pkuwm commented on a change in pull request #673: Add Helix Distributed lock
module
URL: https://github.com/apache/helix/pull/673#discussion_r365347473
##########
File path: bump-up.command
##########
@@ -92,6 +92,23 @@ else
echo "helix-rest/$ivy_file not exist"
fi
+echo "bump up helix-lock/pom.xml"
+sed -i "s/${version}/${new_version}/g" helix-lock/pom.xml
+grep -C 1 "$new_version" helix-lock/pom.xml
+# git diff helix-lock/pom.xml
+
+ivy_file="helix-lock-"$version".ivy"
Review comment:
Nit, I understand the other modules' names are also hardcoded. I would just
make a variable `module_name="helix-lock"` (Or better, can read from pom file)
and reuse the module. I've seen duplicated code in this script, which a for
loop could handle. Maybe we can have another PR to clean this script.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
