zhangmeng916 commented on a change in pull request #673: Add Helix Distributed
lock module
URL: https://github.com/apache/helix/pull/673#discussion_r365421949
##########
File path: bump-up.command
##########
@@ -92,6 +92,23 @@ else
echo "helix-rest/$ivy_file not exist"
fi
+echo "bump up helix-lock/pom.xml"
+sed -i "s/${version}/${new_version}/g" helix-lock/pom.xml
+grep -C 1 "$new_version" helix-lock/pom.xml
+# git diff helix-lock/pom.xml
+
+ivy_file="helix-lock-"$version".ivy"
+new_ivy_file="helix-lock-"$new_version".ivy"
+# echo "$ivy_file"
+if [ -f helix-rest/$ivy_file ]; then
+ echo "bump up helix-lock/$ivy_file"
+ git mv "helix-lock/$ivy_file" "helix-lock/$new_ivy_file"
+ sed -i "s/${version}/${new_version}/g" "helix-lock/$new_ivy_file"
+ grep -C 1 "$new_version" "helix-lock/$new_ivy_file"
+else
+ echo "helix-lock/$ivy_file not exist"
+fi
Review comment:
yeah, ivy files are necessary when we build release internally. Otherwise it
won't work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
