kishoreg commented on issue #680: Question on CrushEd rebalance algorithm and MasterSalve state model for Pinot URL: https://github.com/apache/helix/issues/680#issuecomment-573929154 Thanks Jiajun for the response. Pinot doesn't need rack-awareness for controllers since they are stateless and each partition (which is a pinot-table) is independent. Out of curiosity, what is the problem with OnlineOffline model if there are more than 2 replicas? CrushEd implementation throws an illegal exception even though the scenario is valid and happens every time at startup. We don't see this behavior with AutoRebalanceStrategy. On Mon, Jan 13, 2020 at 3:14 PM Jiajun Wang <[email protected]> wrote: > I had some discussion with Jack offline. My take away is that the > AutoRebalanceStrategy with OnlineOffline state model might work for Pinot > for now. But it has some limitations and may impact future changes. For > example, this strategy is not rack-aware. As for the OnlineOffline state > model, once there are more than 2 replicas, we will have multiple online > replicas. I assume it might cause issues. > > In addition, I'm not sure what does "simplified" mean for Pinot? The > CrushEd algorithm is internally more complicated, but it is more stable and > performs better than the legacy strategy. So eventually, the CrushEd > strategy should help to simplify the application code more. I remember it > is part of the reason we decided to go with the CrushEd strategy. > > @dasahcc <https://github.com/dasahcc> @lei-xia > <https://github.com/lei-xia> Could you please also take a look in case I > missed anything. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/helix/issues/680?email_source=notifications&email_token=AAGPWZ2KICDEM7RAEEAQB6TQ5TYV7A5CNFSM4KGKEUY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI2U4SY#issuecomment-573918795>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAGPWZYNXLISMY3OPK5DR7DQ5TYV7ANCNFSM4KGKEUYQ> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
