kishoreg commented on issue #680: Question on CrushEd rebalance algorithm and MasterSalve state model for Pinot URL: https://github.com/apache/helix/issues/680#issuecomment-573938432 The algorithm should not throw an exception, that’s not part of the strategy interface/contract and is not consistent with other strategies. Throwing illegal state exception is not very useful. On Mon, Jan 13, 2020 at 4:14 PM Jiajun Wang <notificati...@github.com> wrote: > Hi @kishoreg <https://github.com/kishoreg>, > > I agree with the first point, that's why I think there is no problem to > switch for now. > > Regarding the OnlineOffline state model, Helix will try to bring all the > replicas to the topstate "online". But what Pinot needs is only one > topstate replica, right? That is the thing in my mind. Please correct me if > I misunderstand the usage. > > I also took a quick look at the illegal exception thread. On my > understanding, the error log happens due to a lack of participants during > the initial process. Once there are enough participants to become alive, > the controller will be able to rebalance automatically. The only difference > between CrushEd and AutoRebalanceStrategy is that CrushEd complains about > it and print an error log, while the AutoRebalanceStrategy silently returns > an empty mapping without printing error log. > Given this, it won't cause any trouble. Could you please elaborate on the > valid scenario that you mentioned? If we are actually talking about > different scenarios, we can help to revisit the logic and see if there is > any issue in the CrushEd strategy. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/helix/issues/680?email_source=notifications&email_token=AAGPWZ542EKWAAW3XNWDZJTQ5T7XJA5CNFSM4KGKEUY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI2ZIQI#issuecomment-573936705>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAGPWZ65NGRJWEQH2IOZF6LQ5T7XJANCNFSM4KGKEUYQ> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
