i3wangyi commented on a change in pull request #681: Integration test for
controller connect and disconnect
URL: https://github.com/apache/helix/pull/681#discussion_r367036148
##########
File path: helix-core/src/main/java/org/apache/helix/HelixTimerTask.java
##########
@@ -32,4 +32,9 @@
* Stop a timer task
*/
public abstract void stop();
+
+ /**
+ * Validate if the timer task is stopped
+ */
+ public abstract boolean isStopped();
Review comment:
The only exposed interface from ZkHelixManager is `List<HelixTimerTask>
_controllerTimerTasks = xxx` and the actual implementation class is `static
class StatusDumpTask` which is not exposed neither. How could I create a
protected method and make it only visible for the test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
