i3wangyi commented on a change in pull request #681: Integration test for
controller connect and disconnect
URL: https://github.com/apache/helix/pull/681#discussion_r372650313
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/controller/TestControllerLeadershipChange.java
##########
@@ -117,16 +258,17 @@ public void testMissingTopStateDurationMonitoring()
throws Exception {
// Resource lost top state, and manager1 lost leadership for 2000ms,
because manager1 will
// clean monitoring cache after re-gaining leadership, so max value of
hand off duration should
// not have such a large value
- Assert.assertTrue((long) beanServer.getAttribute(resourceMBeanObjectName,
- "PartitionTopStateHandoffDurationGauge.Max") < 500);
+ Assert.assertTrue((long) beanServer
+ .getAttribute(resourceMBeanObjectName,
"PartitionTopStateHandoffDurationGauge.Max") < 500);
participant.syncStop();
manager1.disconnect();
manager2.disconnect();
deleteCluster(clusterName);
}
- private void setLeader(HelixManager manager) throws Exception {
+ private void setLeader(HelixManager manager)
Review comment:
good catch. updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
