pkuwm commented on a change in pull request #653: add Helix properties factory and class URL: https://github.com/apache/helix/pull/653#discussion_r367736356
########## File path: helix-core/src/main/java/org/apache/helix/HelixCloudProperty.java ########## @@ -0,0 +1,179 @@ +package org.apache.helix; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.io.InputStream; +import java.util.Collections; +import java.util.List; +import java.util.Properties; +import org.apache.helix.cloud.constants.CloudProvider; +import org.apache.helix.model.CloudConfig; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * Hold helix cloud properties read from CloudConfig and user defined files. Clients may override the fields from their application. + */ +public class HelixCloudProperty { + private static final Logger LOG = LoggerFactory.getLogger(HelixCloudProperty.class.getName()); + private static final String AZURE_CLOUD_PROPERTY_FILE = SystemPropertyKeys.AZURE_CLOUD_PROPERTIES; + private static final String CLOUD_INFO_SOURCE = "cloud_info_source"; + private static final String CLOUD_INFO_PROCESSFOR_NAME = "cloud_info_processor_name"; + private static final String CLOUD_MAX_RETRY = "cloud_max_retry"; + private static final String CONNECTION_TIMEOUT_MS = "connection_timeout_ms"; + private static final String REQUEST_TIMEOUT_MS = "request_timeout_ms"; + + // Denote whether the instance is considered as in a cloud environment. + private boolean _isCloudEnabled; + + // Unique id of the cloud environment where the instance is in. + private String _cloudId; + + // Cloud environment provider, e.g. Azure, AWS, GCP, etc. + private String _cloudProvider; Review comment: Do you consider making this type as CloudProvider since you already have CloudProvider constants? I think it has some benifits to make advantage of enum CloudProvider: - you don't have to convert between CloudProvider.name() and valueOf(string). - parameter type in the API looks more transparent than a string ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
