pkuwm commented on a change in pull request #653: add Helix properties factory
and class
URL: https://github.com/apache/helix/pull/653#discussion_r367723097
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
##########
@@ -202,6 +205,11 @@ public ZKHelixManager(String clusterName, String
instanceName, InstanceType inst
public ZKHelixManager(String clusterName, String instanceName, InstanceType
instanceType,
String zkAddress, HelixManagerStateListener stateListener) {
+ this(clusterName, instanceName, instanceType, zkAddress,stateListener,
HelixPropertyFactory.getInstance().getHelixManagerProperty(zkAddress,
clusterName));
Review comment:
Nit, may look better to format this long line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
