narendly commented on a change in pull request #690: Reset the WAGED rebalancer
once the controller newly acquires leadership.
URL: https://github.com/apache/helix/pull/690#discussion_r369864168
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -1259,3 +1287,54 @@ private void initPipeline(Thread eventThread,
BaseControllerDataProvider cache)
eventThread.start();
}
}
+
+/**
+ * A wrapper class for the WAGED rebalancer instance.
+ */
+class WagedRebalancerRef {
Review comment:
Do you think it would be better to generalize this into all rebalancers?
For example, `RebalancerRef` could be an interface here that provides things
like `getRebalancer() or createRebalancer(), invalidate()`, etc. so that the
GenericHelixController class does not depend on a specific stateful rebalancer
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
