narendly commented on a change in pull request #690: Reset the WAGED rebalancer once the controller newly acquires leadership. URL: https://github.com/apache/helix/pull/690#discussion_r370758029
########## File path: helix-core/src/main/java/org/apache/helix/controller/stages/AttributeName.java ########## @@ -38,5 +38,6 @@ AsyncFIFOWorkerPool, PipelineType, LastRebalanceFinishTimeStamp, - ControllerDataProvider + ControllerDataProvider, + STATEFUL_REBALANCER Review comment: I think now, with the introduction of a StatefulRebalancer interface, having this name makes sense and pretty clear. What do you think? Also, could we follow the enum convention? Use `StatefulRebalancer` instead? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
