narendly commented on a change in pull request #682: Implement sharding key prefix-tree class URL: https://github.com/apache/helix/pull/682#discussion_r369895018
########## File path: helix-core/src/main/java/org/apache/helix/ShardingKeyTrieNode.java ########## @@ -0,0 +1,66 @@ +package org.apache.helix; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.util.HashMap; +import java.util.Map; + +public class ShardingKeyTrieNode { Review comment: In terms of defining APIs, please review the following pages: https://docs.oracle.com/javase/7/docs/api/javax/swing/tree/TreeNode.html https://fasterxml.github.io/jackson-core/javadoc/2.5/com/fasterxml/jackson/core/TreeNode.html They list some commonly-used APIs for classes like this and you could also learn about what convention is used for naming the methods. We are not going to need all the methods in these examples so let's start simple, but please try to follow the convention as that will help with reducing confusion. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
