narendly commented on a change in pull request #682: Implement sharding key prefix-tree class URL: https://github.com/apache/helix/pull/682#discussion_r369895542
########## File path: helix-core/src/main/java/org/apache/helix/ShardingKeyTrieNode.java ########## @@ -0,0 +1,66 @@ +package org.apache.helix; Review comment: Please create a separate package for this instead of putting it in `org.apache.helix`. Since this will be used by helix-rest, I am fine with creating a package called "metadata-store" or something like that in helix-rest for the time being. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
