pkuwm opened a new pull request #700: Call session aware createEphemeral to create live instance. URL: https://github.com/apache/helix/pull/700 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: Fixes #699 ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: We implemented a new API ZkClient.createEphemeral(path, data, sessionId) to validate the zk session and create a live instance. Currently, live instance creation is still using the old API createEphemeral(path, data) without the session ID. So zk session race condition is not completely fixed. This PR changes the api to use createEphemeral(path, data, sessionId) for live instance creation. ### Tests - [ ] The following tests are written for this issue: - TestParticipantManager.testSessionExpiryCreateLiveInstance - [ ] The following is the result of the "mvn test" command on the appropriate module: Running... ### Commits - [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [ ] In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Code Quality - [ ] My diff has been formatted using helix-style.xml
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
