narendly commented on a change in pull request #700: Call session aware
createEphemeral to create live instance.
URL: https://github.com/apache/helix/pull/700#discussion_r369966009
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java
##########
@@ -201,7 +201,7 @@ private void createLiveInstance() {
do {
retry = false;
try {
- _zkclient.createEphemeral(liveInstancePath, liveInstance.getRecord());
+ _zkclient.createEphemeral(liveInstancePath, liveInstance.getRecord(),
_sessionId);
Review comment:
Question: this `createLiveInstance` method is supposed to check if the
`_sessionId` is still valid or not. Could you point out where we're doing the
check (besides the one happening when we catch `ZkNodeExistsException`)?
Also, is it possible that `_sessionId` is stale? For example, while the
ParticipantManager is in the middle of `handleNewSession`, session expired?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
