jiajunwang commented on a change in pull request #698: Implement Azure cloud
instance information processor
URL: https://github.com/apache/helix/pull/698#discussion_r373212013
##########
File path:
helix-core/src/main/java/org/apache/helix/cloud/azure/AzureCloudInstanceInformation.java
##########
@@ -42,7 +42,13 @@ public String get(String key) {
}
public static class Builder {
- private Map<String, String> _cloudInstanceInfoMap = null;
+ /**
+ * Default constructor
+ */
+ public Builder() {
+ }
+
+ private Map<String, String> _cloudInstanceInfoMap = new HashMap<>();
Review comment:
Feel free to make it final if you are not going to create a new HashMap
later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
