jiajunwang commented on a change in pull request #698: Implement Azure cloud
instance information processor
URL: https://github.com/apache/helix/pull/698#discussion_r373213295
##########
File path:
helix-core/src/main/java/org/apache/helix/cloud/azure/AzureHttpUtil.java
##########
@@ -0,0 +1,45 @@
+package org.apache.helix.cloud.azure;
+
+import javax.net.ssl.SSLException;
+import org.apache.helix.HelixCloudProperty;
+import org.apache.http.client.HttpRequestRetryHandler;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.http.protocol.HttpContext;
+
+import java.io.IOException;
+import java.io.InterruptedIOException;
+import java.net.UnknownHostException;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * A dedicated http client for retrieving information from Azure Instance
Metadata Service
+ */
+class AzureHttpUtil {
+
+ private static Logger LOG =
LoggerFactory.getLogger(AzureHttpUtil.class.getName());
+
+ static CloseableHttpClient getHttpClient(HelixCloudProperty
helixCloudProperty) {
Review comment:
Can we just have this one instead of creating another private method which
has the same logic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
