jiajunwang commented on a change in pull request #662: Mitigate controller
leadership switch latency - improve leader -> standby
URL: https://github.com/apache/helix/pull/662#discussion_r375571641
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java
##########
@@ -501,23 +499,20 @@ private void
subscribeForChangesAsyn(NotificationContext.Type callbackType, Stri
private void subscribeForChanges(NotificationContext.Type callbackType,
String path,
boolean watchChild) {
- logger.info("Subscribing changes listener to path: " + path + ", type: " +
callbackType
- + ", listener: " + _listener);
+ logger.info(
+ "START:INVOKE subscribing changes listener on path: {}, callbackType:
{}, listener: {}, isWatchChild: {}",
Review comment:
START:INVOKE/END:INVOKE are for the callbacks. Please don't use it here. It
will be confusing to whoever debug later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
