jiajunwang commented on a change in pull request #662: Mitigate controller
leadership switch latency - improve leader -> standby
URL: https://github.com/apache/helix/pull/662#discussion_r375572904
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java
##########
@@ -721,6 +714,21 @@ void reset(boolean isShutdown) {
}
}
+ /**
+ * The package private method only closes the batchCallbackProcessor thread
+ * *Caution*: currently it's only used during disconnecting from ZK and the
+ * listeners unsubscription will be taken care by zkClient directly
+ */
+ void closeBatchCallbackProcessor() {
Review comment:
Besides my concern of not sending FINALIZE, this method is a subset of void
reset(boolean isShutdown); I think you can avoid duplicate code.
Of course, please address my concern about not having the FINALIZE first.
Then we can revisit this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
