narendly commented on a change in pull request #731: Add TrieRoutingData
constructor
URL: https://github.com/apache/helix/pull/731#discussion_r376160121
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java
##########
@@ -37,12 +39,14 @@
private final TrieNode _rootNode;
- // TODO: THIS IS A TEMPORARY PLACEHOLDER. A proper constructor will be
created, which will not
- // take in a TrieNode; it instead initializes the rootNode and creates a
trie based on
- // some input data. The constructor is blocked by the implementation of
RoutingDataAccessor, and
- // will therefore be implemented later.
- public TrieRoutingData(TrieNode rootNode) {
- _rootNode = rootNode;
+ public TrieRoutingData(Map<String, List<String>> routingData) throws
InvalidRoutingDataException {
+ if (isRootShardingKey(routingData)) {
Review comment:
Null check on routingData?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
