NealSun96 commented on a change in pull request #731: Add TrieRoutingData
constructor
URL: https://github.com/apache/helix/pull/731#discussion_r376168000
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDirectory.java
##########
@@ -179,10 +179,10 @@ public void refreshRoutingData(String namespace) {
}
if (_routingDataMap != null) {
- MetadataStoreRoutingData newRoutingData =
- new TrieRoutingData(new TrieRoutingData.TrieNode(null, null, false,
null));
+// MetadataStoreRoutingData newRoutingData =
+// new TrieRoutingData(new TrieRoutingData.TrieNode(null, null,
false, null));
// TODO call constructRoutingData() here.
- _routingDataMap.put(namespace, newRoutingData);
+// _routingDataMap.put(namespace, newRoutingData);
Review comment:
@narendly I didn't entirely understand the refresh logic here, actually.
That's why I didn't make the change. Let's sync up so I know what to do here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
