dasahcc commented on a change in pull request #727: Add
MetadataStoreRoutingDataWriter with DistributedLeaderElection
URL: https://github.com/apache/helix/pull/727#discussion_r377259958
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDirectory.java
##########
@@ -132,26 +131,38 @@ public String getMetadataStoreRealm(String namespace,
String shardingKey) {
@Override
public boolean addMetadataStoreRealm(String namespace, String realm) {
- // TODO implement when MetadataStoreRoutingDataWriter is ready
- throw new UnsupportedOperationException();
+ if (!_routingDataWriterMap.containsKey(namespace)) {
Review comment:
This logic looks good to me. I just would like to ask a further question.
Let's say user failed to add realm due to non-exists namespace. Then the user
would like to add the namespace, how they can do it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
