narendly commented on a change in pull request #727: Add
MetadataStoreRoutingDataWriter with DistributedLeaderElection
URL: https://github.com/apache/helix/pull/727#discussion_r377340478
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDirectory.java
##########
@@ -132,26 +131,38 @@ public String getMetadataStoreRealm(String namespace,
String shardingKey) {
@Override
public boolean addMetadataStoreRealm(String namespace, String realm) {
- // TODO implement when MetadataStoreRoutingDataWriter is ready
- throw new UnsupportedOperationException();
+ if (!_routingDataWriterMap.containsKey(namespace)) {
Review comment:
Namespaces are defined in the System config and therefore are static
throughout the lifecycle of the deployment.
It would require a restart of the service.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
